Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gossip 0.8.0 (new cask) #155700

Closed
wants to merge 1 commit into from
Closed

gossip 0.8.0 (new cask) #155700

wants to merge 1 commit into from

Conversation

badonyx
Copy link
Contributor

@badonyx badonyx commented Sep 20, 2023 •
edited
Loading

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --new-cask <cask> worked successfully.
  • brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

brew audit --new-cask option does not exist (?) but succeeds on my system. brew audit --new --cask fails however due to a codesigning issue which there is precedent for accepting (#127827). This issue potentially exists in other existing casks but only appears to get caught for new ones, e.g. brew audit --new --cask bloodhound fails for the same reason.

❯ brew audit --new --cask gossip
==> Downloading https://github.com/mikedilger/gossip/releases/download/v0.8.0/gossip-0.8.0-Darwin-arm64.dmg
Already downloaded: /Users/me/Library/Caches/Homebrew/downloads/47753c8aa684a088f56e0a664224865c424cd58bd2453c1e4b2055245ed0e9fb--gossip-0.8.0-Darwin-arm64.dmg
==> Downloading https://github.com/mikedilger/gossip/releases/download/v0.8.0/gossip-0.8.0-Darwin-arm64.dmg
Already downloaded: /Users/me/Library/Caches/Homebrew/downloads/47753c8aa684a088f56e0a664224865c424cd58bd2453c1e4b2055245ed0e9fb--gossip-0.8.0-Darwin-arm64.dmg
audit for gossip: failed
 - Signature verification failed:
/private/tmp/d20230920-58675-sm6ue2/Gossip.app: code has no resources but signature indicates they must be present

macOS on ARM requires software to be signed.
Please contact the upstream developer to let them know they should sign and notarize their software.
gossip
  * line 8, col 2: Signature verification failed:
    /private/tmp/d20230920-58675-sm6ue2/Gossip.app: code has no resources but signature indicates they must be present

    macOS on ARM requires software to be signed.
    Please contact the upstream developer to let them know they should sign and notarize their software.
Error: 1 problem in 1 cask detected.

I have added an appropriate caveat to guide the user to reinstall without quarantine attributes, if they are sure they want to trust the app, as documented in the Homebrew FAQ.

@miccal
Copy link
Member

miccal commented Sep 20, 2023

Thank you for your submission @badonyx, but we cannot accept it at this time because it does not pass our signature verification check that are a requirement for new submissions:

macOS on ARM requires software to be signed. Please contact the upstream developer to let them know they should sign and notarize their software.

Please consider hosting this in your own Tap and if the developers sign their app in the future we would then be happy to consider adding this to homebrew-cask.

@miccal miccal closed this Sep 20, 2023
@badonyx
Copy link
Contributor Author

badonyx commented Sep 20, 2023

Hi @miccal. The developer is not particularly familiar with Apple development and does not wish to enroll in the Apple Developer program. Could you offer some guidance on how he should sign the app to pass verification?

Also, could you help me understand why this message for macOS on ARM appears also on the checks for the intel build? https://github.com/Homebrew/homebrew-cask/actions/runs/6253066867/job/16977704131

@miccal
Copy link
Member

miccal commented Sep 21, 2023

Hi @miccal. The developer is not particularly familiar with Apple development and does not wish to enroll in the Apple Developer program. Could you offer some guidance on how he should sign the app to pass verification?

No, sorry, I do not know how developers can sign their apps.

Also, could you help me understand why this message for macOS on ARM appears also on the checks for the intel build? https://github.com/Homebrew/homebrew-cask/actions/runs/6253066867/job/16977704131

The signature verification check is always run on new Cask submissions, regardless of the architecture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new cask
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@badonyx @miccal @BrewTestBot